This repository was archived by the owner on Mar 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Basic wiki facilities for Vestibule #17
Open
rdrake98
wants to merge
13
commits into
rubymanor:master
Choose a base branch
from
rdrake98:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9a03779
experimenting with Gemfile to get mysql to connect
rdrake98 a37971c
mysql2 version fixed for clarity
rdrake98 e5dcf0c
need to specify older version of rake
rdrake98 9a5bc5b
database cleaner updated to work with mysql2 - all tests now pass, wh…
rdrake98 85f7602
Merge remote-tracking branch 'upstream/master'
rdrake98 91f8eea
Basic wiki leading straight to proposal creation for unrecognised names
rdrake98 72f6938
Merge remote-tracking branch 'upstream/master'
rdrake98 c133612
Reverting to original Gemfile
rdrake98 b89452d
new?title= instead of moot?title=
rdrake98 0bcfc0e
Links to not-yet-existent proposals black, not blue
rdrake98 f7541ee
@nickname links to that Vestibule user (not Twitter)
rdrake98 db28c6f
[[]] left unchanged
rdrake98 a388997
Merge branch 'wiki'
rdrake98 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,4 +123,6 @@ header .background li { | |
| #selections form, | ||
| #available_selections form { | ||
| float: left; | ||
| } | ||
| } | ||
|
|
||
| .New {color:black;} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The @nikname markup is more problematic than [[this kind]] I think, as I've explored it, because it's much more likely that someone might choose text for a link with @... inside. A clash with an existing Vestibule user nickname would be bad luck, admittedly, but the preprocessing (before any Markdown) is very simplistic at present.
[[Ruby variables are @hlame imho]] is a bit contrived but would create an anchor link within an anchor link, as will similar text for an attempted Markdown link.
I'd want to write the tests for this and plug the hole to a reasonable degree - or back out of the @hlame idiom I think. But the bigger picture of Ruby Manor logistics is now clearer to me in any case. Will come back to this in some form.