Merged
Conversation
The flash[:alert] block was removed from the _devise_error_alert partial, leaving only resource.errors display and leaving authentication alerts to be handled consistently by the global flash message system. Updated the sessions feature spec to match the new error message casing for invalid login attempts.
| <%= flash[:alert] %> | ||
| </div> | ||
| <% end %> | ||
|
|
There was a problem hiding this comment.
The removal of flash[:alert] handling may break error display for certain Devise actions (like lockable, confirmable, or timeoutable strategies) that use flash messages rather than resource errors. Consider verifying that all Devise modules in use display errors correctly, or add a comment explaining why flash alerts are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #419 upgrading to version 5 of Devise.