Fixed unexpected default bundler installation #9167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where bundler was being installed twice during gem update --system - once as a full gem installation in GEM_HOME and once as a default gem in site_ruby. The fix changes the installation approach to only extract executable files and generate bin wrappers, rather than performing a full gem installation.
Key Changes
- Replaced
installer.installwithinstaller.extract_binandinstaller.generate_binto install only executables - Added test coverage to verify executables are present but library files are not extracted
- Added
s.filesto test setup gemspec to properly test file extraction behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/rubygems/commands/setup_command.rb | Modified install_default_bundler_gem to use extract_bin and generate_bin instead of full install, ensuring only executables are extracted for default bundler gem |
| test/rubygems/test_gem_commands_setup_command.rb | Added test assertions to verify executables are present and lib files are absent; added s.files to test gemspec setup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hsbt
force-pushed
the
fix-default-bundler-installation
branch
from
2ad7a90 to
a70e573
Compare
hsbt
added a commit
that referenced
this pull request
Dec 9, 2025
Fixed unexpected default bundler installation (cherry picked from commit 38f6519)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
#7588 intoroduced #9166 and #9159.
I removed
install_as_defaultoption and useinstaller.installingem update --system. It makes to install full files to default bundler gem. So, we have two copy ofbundler-4.0.0under theGEM_HOMEandsite_rubydirectories.That caused to mix same bundler files.
What is your fix for the problem, implemented in this PR?
Use
installer.extract_binandinstaller.generate_bininstead ofinstaller.install.It makes the following result:
Closes #9166
Closes #9159
Make sure the following tasks are checked