Fix more broken links #8416
Merged
Fix more broken links #8416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
changed the title
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-broken-links
branch
from
6aa2f01 to
7da96fd
Compare
The first time you open an issue, you'll get redirected to the CONNTRIBUTING.md file first, where you have the opportunity to read all the documentation. I don't think it's helpful to include links in the template because they are not even clickable. Users would need to copy-paste the link to the address bar of their browser. I think most people will not do that so I believe it's better to show them the different sections and their description right away. This "fixes" some broken links as a side effect.
GitHub UI already provides a link to our CoC, and that one is actually clickable.
deivid-rodriguez
force-pushed
the
deivid-rodriguez/fix-broken-links
branch
from
7da96fd to
a941dfc
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 17, 2025
Fix more broken links (cherry picked from commit 059d684)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Broken links in Bundler documentation.
What is your fix for the problem, implemented in this PR?
Fix the remaining broken links left around after #8159.
Specifically for issue and pull request templates, I decided to remove the links that are not clickable altogether, because they need to be explicitly copy-pasted in order to be viewed and I think most users won't do this, and they should have read CONTRIBUTING docs anyways before contributing because Github's UI leads you there anyways.
Make sure the following tasks are checked