Fix CI and ruby-lsp benchmark #458
Merged
+91
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
force-pushed
the
bump-ruby-lsp-dependencies
branch
4 times, most recently
from
e40c457 to
98e8427
Compare
k0kubun
approved these changes
Jan 8, 2026
st0012
force-pushed
the
bump-ruby-lsp-dependencies
branch
7 times, most recently
from
a98d945 to
325af28
Compare
rafaelfranca
reviewed
Jan 8, 2026
st0012
force-pushed
the
bump-ruby-lsp-dependencies
branch
3 times, most recently
from
55bb0c2 to
fc66b52
Compare
st0012
commented
Jan 8, 2026
| # Benchmarks that need Bundler (e.g., railsbench) set up their own via use_gemfile. | ||
| # This is important when running tests under `bundle exec rake test`. | ||
| result = if defined?(Bundler) | ||
| Bundler.with_unbundled_env do |
Member
Author
There was a problem hiding this comment.
I added here because if someone runs benchmark with bundle, like bundle exec ruby -I harness benchmarks/fib.rb, it should pass & not be affected by project-level bundle too.
Merged
After ruby/ruby#15825, `tsort` becomes a bundled gem and projects using it must declare it as a dependency. `rbs`, which is a dependency of `ruby-lsp`, only added `tsort` in its 4.0 releases. So this change bumps ruby-lsp's dependencies, specifically rbs, to 4.0.
- Add Gemfile with test dependencies (minitest,csv, gruff, etc.) - Pin minitest to version 5.x to avoid breaking changes introduced in minitest 6.x - Require minitest/mock in test_helper.rb for stub method - Update CI to use bundler-cache and bundle exec
st0012
force-pushed
the
bump-ruby-lsp-dependencies
branch
from
fc66b52 to
1d18bb3
Compare
rafaelfranca
approved these changes
Jan 8, 2026
st0012
changed the title
Member
|
🙏 Thanks |
Member
|
To link things together, this broke the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump ruby-lsp dependencies to fix crash with Ruby master
After ruby/ruby#15825,
tsortbecomes a bundled gem and projects using it must declare it as a dependency.rbs, which is a dependency ofruby-lsp, only addedtsortin its 4.0 releases. So this change bumps ruby-lsp's dependencies, specifically rbs, to 4.0.Fix Ruby 4.0 compatibility issues