Skip to content

Conversation

@tompng
Copy link
Member

@tompng tompng commented Oct 18, 2025

Fixes #854

M-n: vi_search_next and M-p: vi_search_prev didn't work because the key was hardcoded as:
"\C-r" is reverse-i-search and "\C-s" is i-search.
("\C-s" normally don't work because of stty configuration (stty -a has stop = ^S)

Also removes hardcoded "\C-h" and "\C-?"

Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ima1zumi ima1zumi merged commit 1d1e808 into ruby:master Oct 19, 2025
43 checks passed
@tompng tompng deleted the no_hardcoded_search_keys branch October 19, 2025 10:18
@ima1zumi ima1zumi added the bug Something isn't working label Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non-incremental downward search displays wrong message

2 participants