Fix Ruby 3.5 compatibility#80
Merged
michaelklishin merged 1 commit intoruby-amqp:mainfrom May 12, 2025
Merged
Conversation
In Ruby 3.5 most of the cgi gem will be removed. Only the various escape/unescape methods will be retained by default. For `CGI.parse`, there is a mostly equivalent method from `URI.decode_www_form`. The data is in a slightly different format, so it needs to be converted. For `CGI.unescape`, depending on the Ruby version. different files need to be required. https://bugs.ruby-lang.org/issues/21258
Member
|
@Earlopain thank you, I will produce a new release now. |
michaelklishin
added a commit
that referenced
this pull request
May 12, 2025
Member
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ruby 3.5 most of the
cgigem will be removed. Only the various escape/unescape methods will be retained by default.For
CGI.parse, there is a mostly equivalent method fromURI.decode_www_form. The data is in a slightly different format, so it needs to be converted.For
CGI.unescape, depending on the Ruby version different files need to be required.This works on Ruby 2.2 which
amq-rubystill supports.https://bugs.ruby-lang.org/issues/21258