refactor: Not needed dependencies removed/moved to peerDependencies#4
Open
muratcorlu wants to merge 2 commits intorubenvanrooij:masterfrom
Open
refactor: Not needed dependencies removed/moved to peerDependencies#4muratcorlu wants to merge 2 commits intorubenvanrooij:masterfrom
muratcorlu wants to merge 2 commits intorubenvanrooij:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aws-lambdaadded to dependencies by mistake. Removed itreflect-metadatamentioned in Readme file to be installed separately. That means it should be a peerDependency. Moved it.install-self-peersexpectingyarnto be installed.yarnis not a dependency. I preferred to run it via npm.ps:
buildcommand is also needs yarn, now. I couldn't find npm equivalent ofyarn cache. But I thinks it's also wise to build project with npm.