restore previous behaviour with \n in strings#11
Conversation
An incompatible change (that actually breaks po parsing after writing) had been introduced with commit e164fcf. If _process returned an array (which is the case for strings containing \n character), array.toString will return a comma separated list, which is not valid po syntax. Added a test to restore the behaviour from before the e164fcf.
Owner
|
Oh right. Makes sense to tackle #2 too. By the way, given that you always provide excellent patches [1], how about I just add you as a committer directly? I'm cool with anything that doesn't break compatibility. [1] Apart from this regression, but making errors is human, no harm done :-) |
rubenv
added a commit
that referenced
this pull request
Jun 23, 2014
restore previous behaviour with \n in strings
Owner
|
Pushed this to NPM as |
Collaborator
Author
|
Thanks :) Adding me as a commiter would be nice. I would still like to keep that PR work-flow, but commiting directly to this repo would simplify it. I would only have to maintain one repo, instead of two. |
Owner
|
I've added you to the repo (so you can make branches here). Feel free to keep sending PRs, I'll happily look at them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An incompatible change (that actually breaks po parsing after writing) had
been introduced with commit e164fcf. If
_process returned an array (which is the case for strings containing \n
character), array.toString will return a comma separated list, which is not
valid po syntax. Added a test to restore the behaviour from before the
e164fcf.
Seems there is still some more to be fixed ;) I found out, that I introduced a bug, that really should be fixed. However, while I was at it, I also started to thinking about #2. At least for the newline case, I verified, that pofile doesn't behave like gettext tools do. I will add some tests for these cases, that will work with mikejholly/node-po#3 merged.