This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Fix jruby support (fork is not supported on this platform) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be awesome to add this pull request... in terms of using jruby and rocco together. Please pull req. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ryan,
I've tried to fix the jruby support by using Albino instead of using local fork to run Pygments. This version passes all the tests on MRI 1.8, all the tests on jruby in 1.8 mode and most of the test on jruby in 1.9 mode. Unfortunately, UTF-8 test is broken. The Albino is using 'posix-spawn' gem to start local Pygments, but the posix-spawn doesn't support any other encoding beside BINARY, actually your issue 4.
The second issue I came across is that the test suite is not running clean with 'redcarpet' but it runs just fine with 'rdiscount'. I've changed gem dependency as well.
So, this pull request in not 100% clean for jruby support, but it may give you some ideas. Actually, it seems like changing Albino to support web service pygments and just calling Albino could be interesting approach.
Cheers,
Maksym.