-
Notifications
You must be signed in to change notification settings - Fork 86
feat: add Gemini CLI support via rtk init --gemini #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ousamabenyounes
wants to merge
9
commits into
rtk-ai:master
Choose a base branch
from
ousamabenyounes:feat/gemini-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+740
−93
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3f9251c
feat: add Gemini CLI support via rtk init --gemini
ousamabenyounes 7cb375c
feat: add Gemini CLI support via rtk init --gemini
ousamabenyounes 23ae1fa
Translate French comments to English in REWRITE_GEMINI_HOOK and relat…
ousamabenyounes 496987d
docs: update version in README from 0.18.1 to 0.20.1
ousamabenyounes 879e921
docs: update version numbers and module counts for v0.20.1
ousamabenyounes 343bca3
Fix test-all.sh failures
ousamabenyounes 2c5a157
feat: auto-detect CLIs with rtk init --global, add --claude flag
ousamabenyounes 02db887
Merge branch 'master' into feat/gemini-support, all conflicts fixed
ousamabenyounes c22f6d0
docs: update version to 0.21.1
ousamabenyounes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep it understandable/simple in six months, I will have taken this approach:
rtk init --claudertk init --geminirtk init --global-> auto CLIs detection (search for ~/.gemini and ~/.claude)(By the way, Hey Ousama, I hope you are doing well 😄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a PR in progress similar to this one.
#158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I’m doing great, hope you are too 🙂
I’m aligned with your approach and implementing it in a lightweight way.
There was #131, but it was considered too large and needed splitting.
So I decided to move forward with a lighter, more focused version instead.
I’ve also applied the requested fixes:
feat: auto-detect CLIs with rtk init --global, add --claude flag
I’m against duplicate work… just like I’m against copy-paste code 😄
Happy to align if #158 already covers it.