Fix multiple bugs related to nested attributes#3
Open
brentdodell wants to merge 3 commits intomasterfrom
Open
Conversation
- If the value is not a hash, we'll let ActiveAttr::Model#initialize take care of it through super() in Forminate#initialize
- The whole reason for cleaning up attributes was that if there were both nested_attributes & prefixed_attributes for the same value, we'd set the nested_attributes, but then they'd get overwritten by the prefixed attributes when super() was called in Forminate#initialize
- In Forminate - AssociationBuilder#attribute_keys_for_cleanup was getting modified with each iteration, reducing the number of keys that were supposed to be cleaned up, resulting in some never getting cleaned up. This gives us a copy that won't be mutated, fixing the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.