Add POM Refactor #124
Open
Add POM Refactor #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvitazwar
commented
Aug 14, 2023
alvitazwar
commented
- Refactor Test cases
- Added New Test case
- Added New Assertions
| await expect(this.page.locator(selectors.leftAlignedValidate).first()).toBeVisible(); | ||
| } | ||
| // this function is used to set Right aligned in top position with iconCount style Social Icons | ||
| async setRightAlignTopPlaceIcon(){ |
Contributor
There was a problem hiding this comment.
@alvitazwar
Add assertion here to validate whether the element is a checkbox for the right alignment is checked.
expect(this.page.locator(selectors.rightAlignment)).toBeChecked();
| } | ||
| // this function is used to set Right aligned in top position with iconCount style Social Icons | ||
| async setRightAlignTopPlaceIcon(){ | ||
| await this.page.locator(selectors.topPlacement).check(); |
Contributor
There was a problem hiding this comment.
same here as well
Contributor
pooja-muchandikar
left a comment
pooja-muchandikar
left a comment
There was a problem hiding this comment.
- Remove the artifacts folder.
- Along with POM implementation, need to update the playwright version as well. Do update the playwright version in package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.