Chronicle official release chart cleanup

[ianpittwood]

• Improvements for chart annotations.
• Values changes.
  • Allow name and namespace overrides in chart values.
  • Add common labels and annotations values to apply to all resources.
  • Moves default tag source to appVersion, image.tag changed to a blank override.
  • Separated an image.registry value from the image.repository value.
  • Improve documentation of values.yaml and add a values.schema.json definition for input validation.
  • An S3 bucket must now be specified in S3 Storage backend is enabled.
• Changes to chart behavior.
  • Resource names are now applied dynamically based on the release name.
  • Additional default recommended Kubernetes labels have been applied to all resources.
  • Storage configuration is now validated and requires at least one of local or s3 storage be enabled.
  • extraSecretMounts can now be specified to mount additional secrets, such as certificates, into the pod.
  • Storage class can now be overridden on the pod's volume claim template.
  • Selector labels definitions between pod and service are now merged into a single definition. Removed the ability to override these values.
  • Add support for additional custom manifest input via extraObjects value.
• Add unittests for chart templates.
• Various Chart.yaml metadata changes.
  • Fix logo URL.
  • Add suggestions for compatible product charts.
  • Add annotation to include source image used in pod.
• Update README.md and other documentation to reflect changes.

[t-margheim]

LGTM! I did leave a couple notes about maybe dropping RetentionPeriod from the docs to match a change on our side.

[markrtucker]

Looks good. I agree with Tim's comments - especially the ones around retention period

[t-margheim]

LGTM!

[bdeitte]

I tried to run this locally with minikube, and I ran into the issue I'm assuming with the docker containers not being updated that I didn't try to solve. I also tried to do a review here, but I'm not a helm expert. Things looked good from what I could see in my limited review.

[bdeitte]

For anybody else curious (other than Ian and Ben who I am sure know this), the one test is failing for a good reason. It's waiting for the latest docker images that don't run as root:

Error: container has runAsNonRoot and image will run as root (pod: "posit-chronicle-pedq9r2wzi-0_posit-test(59eec832-723d-47a6-afdf-b414012687d7)", container: posit-chronicle)

[bdeitte]

Looks great to me

We have changed our approach for storage since my review.