Skip to content

Bump docs theme to v7#666

Merged
AshleyHenry15 merged 2 commits intomainfrom
docs-theme-v7
May 9, 2025
Merged

Bump docs theme to v7#666
AshleyHenry15 merged 2 commits intomainfrom
docs-theme-v7

Conversation

@AshleyHenry15
Copy link
Contributor

Closes #665

Testing:

  • Verify theme v is 7.0.0
  • Cookie icon will NOT be in footer until the site publishes and it goes live. Then WebOps will take over and add the cookie icon and consent via gtm.

@AshleyHenry15 AshleyHenry15 requested review from a team as code owners May 8, 2025 21:51
@AshleyHenry15 AshleyHenry15 requested a review from edavidaja May 8, 2025 21:51
Copy link

@awilliams1275 awilliams1275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cookie icon is part of the footer, and should be placed the same as in https://github.com/rstudio/docs.rstudio.com/blob/main/_quarto.yml.

(GTM can prevent the cookie icon from displaying when it should not display, but GTM does not add the icon to the site if it is missing from the YML file.)

Copy link

@awilliams1275 awilliams1275 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@AshleyHenry15 AshleyHenry15 merged commit 371d62e into main May 9, 2025
7 checks passed
@AshleyHenry15 AshleyHenry15 deleted the docs-theme-v7 branch May 9, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Bump documentation theme to v7

3 participants