Skip to content

update broken link to legacy documentation#655

Merged
bdeitte merged 5 commits intorstudio:mainfrom
Cecilsingh:patch-1
May 7, 2025
Merged

update broken link to legacy documentation#655
bdeitte merged 5 commits intorstudio:mainfrom
Cecilsingh:patch-1

Conversation

@Cecilsingh
Copy link
Contributor

Proposing an update to the broken documentation referenced here: https://github.com/rstudio/docs.rstudio.com/issues/2141

@Cecilsingh Cecilsingh requested review from a team as code owners April 22, 2025 03:37
Co-authored-by: Joshua Spiewak <jspiewak@gmail.com>
Copy link
Contributor Author

@Cecilsingh Cecilsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Just updated the commit

Cecilsingh

This comment was marked as duplicate.

Cecilsingh and others added 2 commits April 29, 2025 09:07
Co-authored-by: Joshua Spiewak <jspiewak@gmail.com>

Co-authored-by: Joshua Spiewak <jspiewak@gmail.com>
@bdeitte
Copy link
Member

bdeitte commented May 5, 2025

@jforest I noticed that these tests are failing, and that the helm-docs check is required. It's failing in here because it can't push to a remote repo from https://github.com/rstudio/helm/blob/main/.github/workflows/chart-doc.yaml#L95, even though there's nothing to push here. Is there a simple way to fix this up?

@jforest
Copy link
Contributor

jforest commented May 6, 2025

@jforest I noticed that these tests are failing, and that the helm-docs check is required. It's failing in here because it can't push to a remote repo from https://github.com/rstudio/helm/blob/main/.github/workflows/chart-doc.yaml#L95, even though there's nothing to push here. Is there a simple way to fix this up?

Unfortunately without recreating this from a branch within this repo, we don't have a pattern yet for making this work. This is because it needs access to the repo secrets (license file) for the tests to work properly. https://github.com/rstudio/helm/actions/runs/14826314981/job/41619850163?pr=655#step:14:741

@bdeitte
Copy link
Member

bdeitte commented May 7, 2025

@jforest Ok, so sounds like we just need to merge this in then without that check. Will do.

@bdeitte bdeitte merged commit 4b8a379 into rstudio:main May 7, 2025
5 of 7 checks passed
@Cecilsingh Cecilsingh deleted the patch-1 branch May 7, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants