Add PWB sharedStorage.subPath parity with homeStorage#651
Merged
Conversation
Contributor
Author
|
Question for @GCRev and @zachhannum, for small changes like this, do you bundle them into a larger change and bump the Chart version there, or should I coordinate the version bump with @kmasiello from her PR here: #649 |
Contributor
|
@samcofer we usually see any change bump the version, so talking to Katie is a good idea, or you could wait until her PR is merged and then come back here to update the minor version number. |
Contributor
Author
|
I'll talk with her about merging and then bringing in her changes! Thanks! |
Contributor
Author
|
@GCRev Alright, this should be ready now. Thanks! |
GCRev
reviewed
Mar 27, 2025
| name: rstudio-workbench | ||
| description: Official Helm chart for Posit Workbench | ||
| version: 0.8.13 | ||
| version: 0.8.14 |
Contributor
Author
|
I suspect that something may be wrong with the GHA checks, as they've been stuck for awhile. Do you know a good way to kick them, or merge in spite of them? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home storage currently supports a
subPathvalue that can be used to select a subPath to mount home directories from. A customer has requested that we also support this functionality in the sharedStorage location.