-
Notifications
You must be signed in to change notification settings - Fork 35
PPM: implement service.targetPort as configurable #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1160315
648c06b
a4c7289
e617369
e63cdc0
1112c7d
52948cb
d080dbe
9bfe46b
6dfbbe9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,8 @@ | ||
| # Changelog | ||
|
|
||
| ## 0.5.45 | ||
|
|
||
| - Allow values for `service.targetPort`, `pod.port`, and `pod.hostAliases` | ||
|
|
||
| ## 0.5.44 | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,8 @@ service: | |
| nodePort: false | ||
| # -- The Service port. This is the port your service will run under. | ||
| port: 80 | ||
| # -- The port to forward to on the Package Manager pod. Also see pod.port | ||
| targetPort: 4242 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Besides Is it possible to use a template variable here so you only have to set Otherwise this is fine of course, as it's still better than what we had before.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| # -- replicas is the number of replica pods to maintain for this service | ||
| replicas: 1 | ||
|
|
@@ -137,8 +139,10 @@ pod: | |
| drop: ["ALL"] | ||
| seccompProfile: | ||
| type: "{{ if .Values.enableSandboxing }}Unconfined{{ else }}RuntimeDefault{{ end }}" | ||
| port: 4242 | ||
| # -- The termination grace period seconds allowed for the pod before shutdown | ||
| terminationGracePeriodSeconds: 120 | ||
| hostAliases: [] | ||
|
|
||
| # -- Extra objects to deploy (value evaluated as a template) | ||
| extraObjects: [] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.