Skip to content

Conversation

@chendaniely
Copy link
Member

@chendaniely chendaniely commented Aug 27, 2019

@chendaniely
Copy link
Member Author

R CMD check is failing because of of the vignettes folder

> checking files in 'vignettes' ... WARNING
  Files in the 'vignettes' directory but no files in 'inst/doc':
    '000-introduction_to_gradethis.Rmd', '010-using_equal.Rmd',
      '990-developers_guide.Rmd'
  Package has no Sweave vignette sources and no VignetteBuilder field.

0 errors v | 1 warning x | 0 notes v
Error: R CMD check found WARNINGs
Execution halted

@schloerke
Copy link
Collaborator

This should fix it...

usethis::use_vignette("tmp")
unlink("vignettes/tmp.Rmd")

@lintr-bot

This comment has been minimized.

@chendaniely
Copy link
Member Author

I'm not exactly sure how to get #77 working, the example in there reports 0/2 tests passing... But I want to at least get some writeup online as soon as possible.

#77 isn't a critical priority right now since it's only for the standalone case, not within learnr. But, it is something that should eventually work

@rstudio rstudio deleted a comment from lintr-bot Nov 1, 2019
@lintr-bot

This comment has been minimized.

@chendaniely
Copy link
Member Author

#81 got merged!!!

I'll fix up the vignettes in here (this will also update the pkgdown website)

chendaniely added a commit that referenced this pull request Mar 24, 2020
@chendaniely chendaniely mentioned this pull request Mar 24, 2020
@chendaniely
Copy link
Member Author

Closing this PR in lieu of #102

chendaniely added a commit that referenced this pull request May 27, 2020
@chendaniely chendaniely deleted the vignettes branch May 27, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants