Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90e99833bb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path: ~/.m2/repository | ||
|
|
||
| - name: Test ${{ matrix.demoapp }} | ||
| run: cd demoapps/${{ matrix.demoapp }} && USE_MAVEN_LOCAL=true ./gradlew test --no-daemon |
There was a problem hiding this comment.
USE_MAVEN_LOCAL=true in this step does not change Gradle repository selection: a repo-wide search (rg USE_MAVEN_LOCAL) finds no code that reads it, and most standalone demoapp settings files (demoapps/cli-starter/settings.gradle.kts, demoapps/jetty-starter/settings.gradle.kts, demoapps/micronaut-starter/settings.gradle.kts, demoapps/starwars/settings.gradle.kts) only configure mavenCentral()/gradlePluginPortal() (no mavenLocal()). Because these apps are pinned to viaductVersion=0.24.0-SNAPSHOT, this workflow will still try to resolve snapshots from Maven Central and fail instead of using the uploaded ~/.m2/repository artifact.
Useful? React with 👍 / 👎.
rstata
force-pushed
the
ci/standalone-demoapp-tests
branch
3 times, most recently
from
26386fa to
a3897f3
Compare
…e it Introduces .github/actions/setup-build, a composite action that wraps setup-java and setup-gradle in one reusable step. Migrates all five jobs in build-and-test.yml to use it, removing the now-redundant inline setup-java, setup-gradle, and actions/cache steps from each job. The build job uses the default cache-read-only=false so it can write the Gradle User Home cache. The four downstream jobs (test, detekt, ktlint, coverage-verification) pass cache-read-only=true — they only need to read the cache written by the build job, and writing from all four simultaneously wastes cache quota and risks evicting useful entries. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a GitHub Actions workflow that publishes Viaduct to Maven Local and tests each demo app against those published artifacts in isolation (USE_MAVEN_LOCAL=true), catching dependency-packaging bugs that composite builds mask via source substitution. - New workflow standalone-demoapp-tests.yml with three jobs: publish-to-maven-local (ubuntu/Java 21), test-demoapps (4-app matrix, ubuntu/Java 21), test-starwars (ubuntu × Java 17+21 matrix) - Uses setup-build composite action for Java/Gradle setup; test jobs pass cache-read-only=true to avoid redundant cache writes - Maven Local artifact upload uses compression-level=0 (JARs are already compressed) and retention-days=1 (only needed within the run) - Adds USE_MAVEN_LOCAL support to demoapps/micronaut-starter so it can resolve Viaduct from Maven Local instead of the composite build - Updates post-slack-alerts.yml to alert on the new workflow's failures Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Three pre-existing issues in build-logic that became visible when
running publishToMavenLocal more carefully:
- build-logic:shared applied kotlin-dsl, which pulls in java-gradle-plugin
and auto-creates a pluginMaven publication. Combined with the explicit
maven publication, this produced duplicate publications and a spurious
"no valid plugin descriptors" warning. Fixed by switching to kotlin("jvm")
(shared has no Gradle API dependencies) and keeping one explicit publication.
- test-fixtures and tools publish Gradle capability variants that cannot
be expressed in Maven POM format, generating noisy metadata warnings.
Suppressed with suppressPomMetadataWarningsFor().
- versioning.gradle.kts logged the resolved version at lifecycle level on
every build. Downgraded to info.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Introduces a publishMinimal Gradle property that strips out everything not needed when publishing to Maven Local for local integration testing: - Skips Dokka javadoc generation and sources jars in viaduct-publishing convention (JavadocJar.Empty(), sourcesJar=false) - Excludes the x/javaapi modules entirely from the build graph via included-builds/core/settings.gradle.kts, avoiding their heavyweight annotation processing and compilation The standalone-demoapp-tests workflow passes -PpublishMinimal to the publishToMavenLocal step to take advantage of this. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rstata
force-pushed
the
ci/standalone-demoapp-tests
branch
from
a3897f3 to
1859a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/actions/setup-buildcomposite action to consolidate the checkout/setup-java/setup-gradle sequencestandalone-demoapp-tests.ymlworkflow: publishes Viaduct to Maven Local, then tests each demo app in isolation withUSE_MAVEN_LOCAL=truepost-slack-alerts.ymlto also alert on failures in the new workflowTest plan
publish-to-maven-localjob completes andmaven-local-repoartifact appears in the workflow runtest-demoappsmatrix shards (cli-starter,jetty-starter,ktor-starter,micronaut-starter) run in parallel and passtest-starwarsmatrix shards (ubuntu-latest×macos-latest× Java17×21) run in parallel and pass🤖 Generated with Claude Code