Skip to content

fix: handle cases where sourceContent is missing #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Sep 8, 2025
Merged

fix: handle cases where sourceContent is missing #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b00f7c
fix: handle cases where sourceContent is missing
chenjiahan Sep 8, 2025
a7f14c2
fix
chenjiahan Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 41 additions & 26 deletions src/generateError.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,18 @@ export async function generateError({
rootPath: string;
exclude?: CheckSyntaxExclude;
}): Promise<ECMASyntaxError | null> {
const relativeOutputPath = filepath.replace(rootPath, '');
let error = await tryGenerateErrorFromSourceMap({
err,
filepath,
rootPath,
code,
outputFilepath: filepath,
relativeOutputPath,
});

if (!error) {
const path = filepath.replace(rootPath, '');
error = new ECMASyntaxError(err.message, {
source: {
path,
path: relativeOutputPath,
line: err.loc.line,
column: err.loc.column,
code: displayCodePointer(code, err.pos),
Expand Down Expand Up @@ -75,14 +76,16 @@ export function makeCodeFrame(lines: string[], highlightIndex: number) {

async function tryGenerateErrorFromSourceMap({
err,
filepath,
rootPath,
code,
outputFilepath,
relativeOutputPath,
}: {
err: AcornParseError;
filepath: string;
rootPath: string;
code: string;
outputFilepath: string;
relativeOutputPath: string;
}): Promise<ECMASyntaxError | null> {
const sourceMapPath = `${filepath}.map`;
const sourceMapPath = `${outputFilepath}.map`;

if (!fs.existsSync(sourceMapPath)) {
return null;
Expand All @@ -91,37 +94,49 @@ async function tryGenerateErrorFromSourceMap({
try {
const sourcemap = await fs.promises.readFile(sourceMapPath, 'utf-8');
const consumer = await new SourceMapConsumer(sourcemap);
const sm = consumer.originalPositionFor({
const mappedPosition = consumer.originalPositionFor({
line: err.loc.line,
column: err.loc.column,
});
if (!sm.source) {

if (!mappedPosition.source) {
return null;
}
const { sources } = consumer;

const smIndex = sources.indexOf(sm.source);

const smContent: string = JSON.parse(sourcemap)?.sourcesContent?.[smIndex];

if (!smContent) {
return null;
const { sources } = consumer;
const sourceIndex = sources.indexOf(mappedPosition.source);
const sourceContent: string | null =
JSON.parse(sourcemap).sourcesContent?.[sourceIndex];
const sourcePath = mappedPosition.source.replace(/webpack:\/\/(tmp)?/g, '');

if (!sourceContent) {
return new ECMASyntaxError(err.message, {
source: {
path: sourcePath,
line: mappedPosition.line ?? 0,
column: mappedPosition.column ?? 0,
code: displayCodePointer(code, err.pos),
},
output: {
path: relativeOutputPath,
line: err.loc.line,
column: err.loc.column,
},
});
}

const path = sm.source.replace(/webpack:\/\/(tmp)?/g, '');
const relativeFilepath = filepath.replace(rootPath, '');
const rawLines = smContent.split(/\r?\n/g);
const highlightLine = (sm.line ?? 1) - 1;
const rawLines = sourceContent.split(/\r?\n/g);
const highlightLine = (mappedPosition.line ?? 1) - 1;

return new ECMASyntaxError(err.message, {
source: {
path,
line: sm.line ?? 0,
column: sm.column ?? 0,
path: sourcePath,
line: mappedPosition.line ?? 0,
column: mappedPosition.column ?? 0,
code: makeCodeFrame(rawLines, highlightLine),
},
output: {
path: relativeFilepath,
path: relativeOutputPath,
line: err.loc.line,
column: err.loc.column,
},
Expand Down
Loading