Removed duplicated classes from bitcoin package#15
Open
rmoreliovlabs wants to merge 2 commits intomasterfrom
Open
Removed duplicated classes from bitcoin package#15rmoreliovlabs wants to merge 2 commits intomasterfrom
rmoreliovlabs wants to merge 2 commits intomasterfrom
Conversation
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
3 times, most recently
from
2c6a156 to
a1b912b
Compare
Vovchyk
previously approved these changes
Feb 22, 2022
josedahlquist
previously approved these changes
Feb 23, 2022
rmoreliovlabs
dismissed stale reviews from josedahlquist and Vovchyk
via
a0fcdb1
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
from
a1b912b to
a0fcdb1
Compare
VaWheel
reviewed
Mar 30, 2022
josedahlquist
left a comment
josedahlquist
left a comment
There was a problem hiding this comment.
could you please add to .gitignore the .DS_STORE files? and remove them from your PR?
rmoreliovlabs
force-pushed
the
remove-duplicate-libraries
branch
from
73bddc8 to
a987d17
Compare
Author
|
Done @josedahlquist |
kelvinator07
approved these changes
Aug 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed duplicated classes already existing in
co.rsk:native:core/src/main/java/org/bitcoin/NativeSecp256k1.javacore/src/main/java/org/bitcoin/NativeSecp256k1Util.javacore/src/main/java/org/bitcoin/Secp256k1Context.java