feat(artist-page): allow loading all albums#108
Open
qvalentin wants to merge 1 commit intorramiachraf:mainfrom
Open
feat(artist-page): allow loading all albums#108qvalentin wants to merge 1 commit intorramiachraf:mainfrom
qvalentin wants to merge 1 commit intorramiachraf:mainfrom
Conversation
qvalentin
commented
Mar 21, 2026
Comment on lines
+75
to
+79
| Albums []struct { | ||
| Id int `json:"id"` | ||
| Image string `json:"cover_art_thumbnail_url"` | ||
| Name string `json:"name"` | ||
| URL string `json:"url"` |
Contributor
Author
There was a problem hiding this comment.
Kind of redundant, but idk if we should extract it
| } | ||
| } | ||
|
|
||
| func (a *Artist) GetAllAlbums() error { |
Contributor
Author
There was a problem hiding this comment.
This has quite some logic that does not really fit into /data but on the other hand its well suited for an function on (a *Artist).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another todo I had from #61