Draft
Conversation
73dc13d to
04fe179
Compare
Author
|
I believe adding this test brings k256 up to feature parity with the others. Is anything else blocking it from being merged into main as a feature? Linking to the secp256k1 DHKEM author's note on why it probably will not make it into an RFC even though it's ready for action.
|
04fe179 to
865adf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Known Answer Tests are missing in the original k256 implementation on the unstable-k256 branch.
There are a couple of things to solve in order to get them in here.
test-vectors-5f503c5.jsongenerated from the reference implementation do not include known answers for k256 since it is not defined in RFC 9080skRmandskSmare the identical butikmSandikmRfrom which they are derived (afaiu) are different as discussed in hpke-rs h/t @franziskuskiefer for discovering this.I'm working on generating test vectors and having another implementation test them as well.