Normalizing by decimal delta between asset and vault#123
Open
alcueca wants to merge 2 commits intoroycoprotocol:mainfrom
Open
Normalizing by decimal delta between asset and vault#123alcueca wants to merge 2 commits intoroycoprotocol:mainfrom
alcueca wants to merge 2 commits intoroycoprotocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not as elegant as normalizing by assets, but hopefully safer.
If the vault has a higher decimal count that its asset, we use the difference as a scalar to:
I haven't included the tweak to only pull rewards that are expected to be distributed.
Normalizing the rate up shouldn't overflow, because we upcast from u96 to u256.
There would be some rounding down of user rewards when accumulating them, I do not know the actual impact.