-
Notifications
You must be signed in to change notification settings - Fork 0
v1.1.0 #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.1.0 #138
Conversation
Merge pull request #133 from rowicy/develop
Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
- Add optional externalUrl field to blog schema - Update BlogCard to handle external URLs with icon and badge - Add sample external blog entry for demonstration - External links open in new tab with proper security attributes Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
Use a complete article path instead of root URL Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
Add author and tag filtering to blog pages
…tion-to-blog-page
Add pagination to blog page
…al-links-to-blog-list
…g-list Add external article link support to blog list
✅ Deploy Preview for rowicy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces a comprehensive blog listing and filtering system with client-side pagination, external blog link support, and enhanced navigation. The implementation adds interactive filtering by author and tag, with proper URL encoding for special characters, and improves the blog card component to handle both internal and external articles with appropriate visual indicators.
- Implements client-side pagination (20 posts per page) with URL synchronization and accessible controls
- Adds filtering capabilities by author and tag with dedicated dynamic route pages
- Enhances blog cards to support external articles with visual indicators and clickable tag/author links
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/BlogList.tsx | Implements paginated blog list with URL state management and client-side navigation |
| src/components/BlogPagination.tsx | Provides accessible pagination controls with ellipsis for large page counts |
| src/components/ui/pagination.tsx | Foundational pagination UI components using shadcn/ui patterns |
| src/components/BlogFilter.astro | Creates filter interface showing available authors and tags |
| src/components/BlogCard.tsx | Enhances card with external link support, clickable tags/authors, and visual indicators |
| src/pages/blog.astro | Updates main blog page to use new list and filter components |
| src/pages/blog/author/[name].astro | Dynamic page for filtering blogs by specific author |
| src/pages/blog/tag/[tag].astro | Dynamic page for filtering blogs by specific tag with URL encoding |
| src/lib/getBlog.ts | Fixes typo in variable name from "sortesBlogs" to "sortsBlogs" |
| src/lib/getTags.ts | Utility to fetch and encode unique tags for filtering and routing |
| src/content/config.ts | Adds optional externalUrl field to blog schema |
| src/content/blog/*.md | Adds new blog posts with external URLs and metadata |
| README.md | Removes specific version numbers for Node.js and Astro |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@naoki-00-ito I've opened a new pull request, #139, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: naoki-00-ito <117070296+naoki-00-ito@users.noreply.github.com>
Fix grammatically incorrect variable name in getBlog
Merge pull request #138 from rowicy/develop
This pull request introduces a comprehensive blog listing and filtering/pagination system, along with support for external blog links and improved content metadata. The changes add new components for filtering by author and tag, implement client-side pagination, and enhance the
BlogCardto handle external articles. Several new blog posts are also added, and the content schema is updated to support external URLs.Blog Listing, Filtering, and Pagination:
BlogListcomponent for paginated blog display, with client-side navigation and URL sync (src/components/BlogList.tsx).BlogPaginationand supporting UI components for accessible, styled pagination controls (src/components/BlogPagination.tsx,src/components/ui/pagination.tsx) [1] [2].BlogFiltercomponent to allow filtering blogs by author and tag, with dynamic generation of filter options (src/components/BlogFilter.astro).BlogListandBlogFiltercomponents, replacing the previous static list (src/pages/blog.astro).Blog Card and External Links:
BlogCardto support external articles: displays an external link icon, "外部記事" badge, and opens links in a new tab when appropriate. Tag and author links are now clickable and styled for clarity (src/components/BlogCard.tsx) [1] [2] [3].Content Structure and Metadata:
externalUrlfor supporting external blog links (src/content/config.ts).src/content/blog/*.md) [1] [2] [3] [4].src/lib/getBlog.ts).src/lib/getTags.ts).Author and Tag Filtered Pages:
src/pages/blog/author/[name].astro,src/pages/blog/tag/[tag].astro) (src/pages/blog/author/[name].astroR1-R52, src/pages/blog/tag/[tag].astroR1-R57).Other:
README.mdto remove specific version numbers for Node.js and Astro, reflecting a more general setup.These changes collectively provide a much richer and more user-friendly blog browsing experience, with robust filtering, pagination, and support for both internal and external articles.