Add appropriate tokio features to Cargo.toml#2
Closed
ErwanDL wants to merge 1 commit intorouterify:masterfrom
Closed
Add appropriate tokio features to Cargo.toml#2ErwanDL wants to merge 1 commit intorouterify:masterfrom
ErwanDL wants to merge 1 commit intorouterify:masterfrom
Conversation
"rt-core" is required by `tokio::spawn`, "io-util" is required by `tokio::io::copy`
Member
|
Apologies for the delayed response. I will try to look into the PR soon. |
Member
|
@ErwanDL maybe we should update to tokio 1 right away? |
Author
|
@gsserge I agree, that PR was just really a temporary fix while I was working on updating to tokio v1. However, I have tried to do the update to tokio v1 on this branch, but I am somewhat stuck at the moment as |
|
Have pushed a new PR here: #3 Currently using my fork of async-pipe-rs until routerify/async-pipe-rs#10 is merged. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on routerify/routerify-websocket#3, I encountered issues when trying to build the test_stream_body.rs example, after having updated routerify-websocket to use tokio 1.x.
I am not 100% sure why the error did not arise while routerify-websocket was still using tokio 0.2 (probably due to some cargo dependency resolution shenanigans), but it seems to me that stream-body's Cargo.toml should list the features that are used: "rt-core" is required by
tokio::spawnand "io-util" is required bytokio::io::copy, both used inbody.rs.Having this PR merged will allow me to continue working on updating routerify-websocket. I may need to follow up with another PR on stream-body (updating to tokio 1.x and hyper 0.14) before being able to push the routerify-websocket update.