Merged
Conversation
justmobilize
commented
Dec 10, 2025
| field=models.TextField(blank=True, null=True), | ||
| ) | ||
| ]""" # noqa ROU102 | ||
| ]""" |
Contributor
Author
There was a problem hiding this comment.
not sure why it yelled before, but these aren't needed
| "def", | ||
| ) | ||
|
|
||
| MAX_BLANK_LINES_AFTER_COMMENT = 2 |
| UNDEFINED = object() | ||
|
|
||
|
|
||
| class LintClass: |
Contributor
Author
There was a problem hiding this comment.
the goal is to move all of them to a self contained class, do the main class doesn't balloon
| version = importlib_metadata.version(__name__) | ||
|
|
||
| def __init__(self, tree, file_tokens: list[tokenize.TokenInfo]) -> None: | ||
| def __init__(self, tree, file_tokens: list[tokenize.TokenInfo], filename: str) -> None: |
Contributor
Author
There was a problem hiding this comment.
added filename, so a rule can ignore certain files
| raise NotImplementedError() | ||
|
|
||
|
|
||
| class ModelFieldDefinitions(LintClass): |
Contributor
Author
There was a problem hiding this comment.
here is the new one
|
|
||
| class ModelFieldDefinitions(LintClass): | ||
|
|
||
| SWAP_VALUES = { |
Contributor
Author
There was a problem hiding this comment.
for cases where the db_default isn't the same code wise, but does the same thing
tomharel
approved these changes
Dec 10, 2025
robotadam
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.