Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 10, 2025

Updates the requirements on libloading to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [libloading](https://github.com/nagisa/rust_libloading) to permit the latest version.
- [Commits](nagisa/rust_libloading@0.8.0...0.9.0)

---
updated-dependencies:
- dependency-name: libloading
  dependency-version: 0.9.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 10, 2025
@WardBrian
Copy link
Collaborator

@aseyboldt -- mind weighing in on how much we should care about our MSRV?

0.9 of libloading bumps their MSRV to 1.88 (released in June of this year), our cargo.toml still lists 1.69 (April 2023).

Is there a good way to actually test that we still even compile with the listed MSRV?

@bob-carpenter
Copy link
Collaborator

What is "MSRV"? I tried a web search but wasn't sure what you meant here.

@WardBrian
Copy link
Collaborator

WardBrian commented Nov 10, 2025

(this is blocked on a bindgen conflict, anyway, but still worth deciding on)

@WardBrian
Copy link
Collaborator

Minimum Supported Rust Version

@nagisa
Copy link

nagisa commented Nov 10, 2025

FWIW the broad community consensus is to support a release predating current stable by two versions when releasing libraries. If 1.88 is for some reason a problem, I can still scale back the requirement to IIRC 1.81, but not earlier as we started using features released in that version in libloading 0.9.

@WardBrian
Copy link
Collaborator

rust-lang/rust-bindgen#3315 is merged, but until bindgen does a release we won't be able to merge this

@aseyboldt
Copy link
Contributor

I mostly agree with @nagisa, but wouldn't worry about the rust version too much. I think the main reason to support older rust versions is if you want to make packages for different linux distributions. Most rust developers will just be using rustup, where it is easy to get the latest release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants