-
Notifications
You must be signed in to change notification settings - Fork 12
Update libloading requirement from 0.8.0 to 0.9.0 in /rust #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updates the requirements on [libloading](https://github.com/nagisa/rust_libloading) to permit the latest version. - [Commits](nagisa/rust_libloading@0.8.0...0.9.0) --- updated-dependencies: - dependency-name: libloading dependency-version: 0.9.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
@aseyboldt -- mind weighing in on how much we should care about our MSRV? 0.9 of libloading bumps their MSRV to 1.88 (released in June of this year), our cargo.toml still lists 1.69 (April 2023). Is there a good way to actually test that we still even compile with the listed MSRV? |
|
What is "MSRV"? I tried a web search but wasn't sure what you meant here. |
|
(this is blocked on a |
|
Minimum Supported Rust Version |
|
FWIW the broad community consensus is to support a release predating current stable by two versions when releasing libraries. If 1.88 is for some reason a problem, I can still scale back the requirement to IIRC 1.81, but not earlier as we started using features released in that version in libloading 0.9. |
|
rust-lang/rust-bindgen#3315 is merged, but until bindgen does a release we won't be able to merge this |
|
I mostly agree with @nagisa, but wouldn't worry about the rust version too much. I think the main reason to support older rust versions is if you want to make packages for different linux distributions. Most rust developers will just be using rustup, where it is easy to get the latest release? |
Updates the requirements on libloading to permit the latest version.
Commits
dab97c50.9.0 release ritese893804refactor: simplify null checks, remove some iffy implementations4b98285add no-std supportf4ec9e7test: try to fix msys (#182)9b798ebPrepare for 0.8.9 releasef5f8cb0Migrate from windows-targets to windows-link7c04bebBump MSRV to 1.71 for windows-link559e465Format with cargo fmtdb35813Fix elided lifetimes warning83f08b8Release 0.8.8Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)