Generation of new docs via Github Actions#130
Generation of new docs via Github Actions#130vyrzdev wants to merge 27 commits intorossmacarthur:masterfrom
Conversation
- When installing through pip, no sphinx-build command was installed
- I think it was importing the pip installed serde package from your pip install library, now imports the local library from the directory - Caveat: Now just docs must be run from the project root.
|
Hey @vyrzdev 👋, thanks for the PR. I'll share some of my thoughts as to how this can be improved: Since sphinx builds the docs to |
| @@ -0,0 +1,36 @@ | |||
| # Triggers the workflows on push or pull request events but only for the main branch | |||
| name: Generate new docs. | |||
There was a problem hiding this comment.
I would prefer if this was just docs. Same with the file name.
| with: | ||
| ref: master |
There was a problem hiding this comment.
Not sure I understand why this is here 🤔. I think it would be assumed that the docs would be built from the branch running the workflow not always from master.
| cp -r ../html_docs_swap_folder/* ./ | ||
| git add . | ||
| git diff-index --quiet HEAD || git commit -m "publish docs for $(git -C ../../.. rev-parse --short HEAD)" | ||
| git push No newline at end of file |
There was a problem hiding this comment.
See my comment on the PR about using an action for this
This should work great, although I'd like to hear your input on how I'm overwriting the existing branch completely.
Theres a little bit of hackiness when I include the library in the PYTHONPATH env variable to get it to import properly in conf.py.
Currently the workflow is: