Conversation
…s to the top, normalizing directory paths, and adding opened files to recent items.
…d reset logic, enhance catalog connection error messages, and simplify error display in DataLakeTablesView.
📝 WalkthroughWalkthroughSorts and de-duplicates recent items and caps them at 50; normalizes directory paths for cloud explorer recent entries; adds a form reset on wizard close; removes several console.log statements across DuckLake adapters and extension manager; and makes one DuckLake error message include the cause text when present. Changes
Sequence Diagram(s)(omitted — changes are not a new multi-component control flow requiring visualization) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/renderer/components/dataLake/DataLakeTableImportWizard.tsx`:
- Around line 146-160: The Dialog reset currently happens in a useEffect
watching open which runs after open flips to false and causes a mid-animation
render that snaps UI back; fix by deferring state resets until the Dialog fully
closes—either call the same reset sequence (setActiveStep, setSourceType,
setTableName, setSourceUrl, setFilePath, setPartitionColumnsText, setError)
inside handleClose before calling onClose (belt-and-suspenders), or remove that
useEffect and pass a TransitionProps.onExited callback to the Dialog to perform
the resets after the exit animation completes; look for handleClose,
useEffect([open]), and the set* state setters to implement the change.
🧹 Nitpick comments (1)
src/renderer/components/cloudExplorer/ExplorerBucketContent.tsx (1)
263-280: Good path normalization for directory recent items.Ensuring a trailing slash on directory paths prevents duplicate recent-item entries caused by inconsistent path representations (e.g.,
foo/barvsfoo/bar/).Minor note: the
elsebranch (Lines 274-280) logs atconsole.errorlevel, butpathbeing empty is an expected case (e.g., navigating to the bucket root via the "Home" breadcrumb). Consider downgrading toconsole.warnor guarding the log to avoid noisy error output during normal navigation.Suggested tweak
- } else { - // eslint-disable-next-line no-console - console.error( - 'Skipping recent item addition: connection or path missing', - { connection, path }, - ); + } else if (path) { + // Only warn when path is present but connection is missing (unexpected) + // eslint-disable-next-line no-console + console.warn( + 'Skipping recent item addition: connection missing', + { connection, path }, + ); }
…p instead of `useEffect`.
Summary by CodeRabbit
New Features
Bug Fixes
Style
Chores