Add Firo RPC scanner implementation#7
Merged
vorujack merged 6 commits intorosen-bridge:devfrom Feb 14, 2026
Merged
Conversation
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
2 times, most recently
from
b85d50a to
5b331d4
Compare
RaaCT0R
requested changes
Feb 2, 2026
packages/observation-extractors/firo-observation-extractor/CHANGELOG.md
Outdated
Show resolved
Hide resolved
packages/observation-extractors/firo-observation-extractor/package.json
Outdated
Show resolved
Hide resolved
.../observation-extractors/firo-observation-extractor/tests/firoRpcObservationExtractor.spec.ts
Outdated
Show resolved
Hide resolved
packages/observation-extractors/firo-observation-extractor/package.json
Outdated
Show resolved
Hide resolved
packages/observation-extractors/firo-observation-extractor/README.md
Outdated
Show resolved
Hide resolved
Contributor
Author
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
a11b459 to
affecac
Compare
Contributor
Author
|
No content change. Just rebased to the latest |
RaaCT0R
requested changes
Feb 10, 2026
packages/scanners/firo-rpc-scanner/tests/network/firoRpcNetwork.spec.ts
Outdated
Show resolved
Hide resolved
packages/scanners/firo-rpc-scanner/tests/network/firoRpcNetwork.spec.ts
Outdated
Show resolved
Hide resolved
packages/scanners/firo-rpc-scanner/tests/network/firoRpcNetwork.spec.ts
Outdated
Show resolved
Hide resolved
packages/scanners/firo-rpc-scanner/tests/network/firoRpcNetwork.spec.ts
Outdated
Show resolved
Hide resolved
packages/scanners/firo-rpc-scanner/tests/network/firoRpcNetwork.spec.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review, @RaaCT0R. I have addressed all the issues raised. |
RaaCT0R
approved these changes
Feb 11, 2026
vorujack
requested changes
Feb 14, 2026
Contributor
vorujack
left a comment
vorujack
left a comment
There was a problem hiding this comment.
Also please sync with base branch
packages/observation-extractors/firo-observation-extractor/package.json
Outdated
Show resolved
Hide resolved
packages/scanners/firo-rpc-scanner/lib/network/firoRpcNetwork.ts
Outdated
Show resolved
Hide resolved
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
7736a87 to
59f381c
Compare
Contributor
Author
Rebased to the latest master: 8bfa13e |
- Remove tests from firo-observation-extractor - Rename getBlockTxInfo to getBlockInfo - Use a generic type for makeRpcCall - Remove getAddressBalance - Some minor changes
navidR
force-pushed
the
feature/dev-aleflm-add-firo
branch
from
8bfa13e to
c1ad944
Compare
vorujack
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the @rosen-bridge/firo-rpc-scanner package, designed to facilitate blockchain monitoring for the Firo network via JSON-RPC interactions. It includes the implementation of the FiroRpcNetworklayer for retrieving block and transaction data, the FiroRpcScanner class for integrating with the general abstract scanner architecture, and comprehensive type definitions and unit tests to ensure robust data processing.