Skip to content

Expose type hash to typesupport structs (rep2011)#95

Merged
clalancette merged 7 commits intoros2:rollingfrom
emersonknapp:emersonknapp/type-version-hash
Mar 15, 2023
Merged

Expose type hash to typesupport structs (rep2011)#95
clalancette merged 7 commits intoros2:rollingfrom
emersonknapp:emersonknapp/type-version-hash

Conversation

@emersonknapp
Copy link
Collaborator

@emersonknapp emersonknapp commented Feb 17, 2023 •
edited
Loading

Part of ros2/ros2#1159
Depends on ros2/rosidl#722

Make the codegen type hash available to typesupport struct for distribution during discovery. See ros2/rmw_fastrtps#671 for usage

This was referenced Feb 17, 2023
Closed
Merged
@emersonknapp emersonknapp changed the title [WIP] Expose type hash to typesupport structs for use in RMW [WIP] Expose type hash to typesupport structs (rep2011) Feb 21, 2023
@emersonknapp emersonknapp marked this pull request as ready for review February 23, 2023 21:50
@emersonknapp emersonknapp mentioned this pull request Feb 23, 2023
Merged
@emersonknapp emersonknapp changed the title [WIP] Expose type hash to typesupport structs (rep2011) Expose type hash to typesupport structs (rep2011) Mar 2, 2023
@emersonknapp
Probably need to expose the type hash through typesupport struct
7d1fea2 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Exposing the generated type hash through typesupport callbacks struct
6bc5797 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Service hash introspection todo
bfb795a 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
First pass type hash struct
60b1bb8 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Code cleanup
1b13aca 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Update to use new initializer for Windows
1bd3c1d 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Add service type hash
d4080e0 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp emersonknapp force-pushed the emersonknapp/type-version-hash branch from a8e67db to d4080e0 Compare March 13, 2023 06:21
@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Mar 13, 2023

@sloretz this is ready for review

@sloretz
Copy link
Contributor

sloretz commented Mar 13, 2023

@sloretz this is ready for review

I haven't been keeping up with this one. It would take me a bit to read the context. @clalancette would you be willing to review it. I see you've reviewed ros2/rosidl#722, and this PR looks like a fairly small addition.

@clalancette
Copy link
Contributor

clalancette commented Mar 13, 2023

@clalancette would you be willing to review it. I see you've reviewed ros2/rosidl#722, and this PR looks like a fairly small addition.

Yes, I will be reviewing.

@clalancette
Copy link
Contributor

clalancette commented Mar 15, 2023

With ros2/rosidl#722 now merged, here is CI with just this change:

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@emersonknapp
Copy link
Collaborator Author

emersonknapp commented Mar 15, 2023

@clalancette should we be concerned about the rcl logging test failure on Windows? It does seem really unrelated.

@clalancette
Copy link
Contributor

clalancette commented Mar 15, 2023

@clalancette should we be concerned about the rcl logging test failure on Windows? It does seem really unrelated.

Those are known flakes, unrelated to this. This looks good now, I'll go ahead and merge.

@clalancette clalancette merged commit 166ab45 into ros2:rolling Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clalancette clalancette clalancette approved these changes

@sloretz sloretz Awaiting requested review from sloretz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emersonknapp @sloretz @clalancette