Skip to content

Runtime Interface Reflection: rosidl_dynamic_typesupport#1

Merged
wjwwood merged 33 commits intorollingfrom
runtime_interface_reflection
Apr 8, 2023
Merged

Runtime Interface Reflection: rosidl_dynamic_typesupport#1
wjwwood merged 33 commits intorollingfrom
runtime_interface_reflection

Conversation

@methylDragon
Copy link
Collaborator

@methylDragon methylDragon commented Mar 8, 2023 •
edited
Loading

This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
Depends on (and is built on top of the branch of):

After merging this, merge:

Description

This PR provisions a serialization support library interface, defining the interface to be fulfilled in downstream serialization support libraries.

TODO

  • Add a few missing interfaces
  • Migrate to use the type_description_interfaces package instead of the internal type description struct
  • Add type description message utils

@methylDragon
Initial Implementation
40d3626 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon mentioned this pull request Mar 8, 2023
Open
31 tasks
@methylDragon methylDragon marked this pull request as draft March 8, 2023 23:25
@methylDragon methylDragon mentioned this pull request Mar 9, 2023
Merged
@methylDragon
Implement ser and deser, and use type description message
353f6c5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 2c27057 to 353f6c5 Compare March 15, 2023 18:32
@methylDragon
Migrate to rosidl type description
4a98c20 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 1bd6731 to 4a98c20 Compare March 16, 2023 17:34
@methylDragon
Fix const and memory issues
de57924 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 0f6c71f to de57924 Compare March 17, 2023 05:58
@methylDragon
Implement init type builder from description
d00e091 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Clean up package
5e78206 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 45870bc to 4b5e30c Compare March 19, 2023 23:25
@methylDragon
Add name getters
354aba8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 4b5e30c to 354aba8 Compare March 20, 2023 01:21
@methylDragon
Reorder ID arg
aad45d3 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add support for bounded strings
fe0822a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Update complex value insertion
d95a8a1 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 838c3c2 to 91b2b08 Compare March 20, 2023 04:33
@methylDragon
Beautify
8746aab 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 91b2b08 to 8746aab Compare March 20, 2023 04:38
@methylDragon methylDragon mentioned this pull request Mar 20, 2023
Closed
@methylDragon
Handle wstring
b39a2e0 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 959a014 to 73ec573 Compare March 21, 2023 22:55
@methylDragon
Implement serialization support destroy
3a036ab 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 73ec573 to 3a036ab Compare March 21, 2023 22:57
@methylDragon methylDragon marked this pull request as ready for review March 22, 2023 00:01
@methylDragon
Implement methods to add complex member with builders
1fbdab5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add visibility macros
0d15b2c 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from d43e753 to 8a67bfa Compare March 24, 2023 09:39
@methylDragon
Beautify
3ace141 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Use allocators for memory management
156cf41 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from d1edc8d to 156cf41 Compare March 29, 2023 08:44
@methylDragon
Add fixed string support
7a0d4f8 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Fix C linkage
7f0bd21 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Migrate all void methods to use return types
e2ba4b5 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 18c837c to e2ba4b5 Compare March 31, 2023 07:28
@methylDragon
Migrate remaining methods to use return types
5eb4931 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Lint
f7ac18a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 523d9a4 to f7ac18a Compare April 1, 2023 12:02
@methylDragon
Fix windows build
5beefea 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from cf58363 to b5376a9 Compare April 4, 2023 13:10
@methylDragon
Move dynamic type support struct to rosidl and fix mem issues
36acf35 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from b5376a9 to 36acf35 Compare April 4, 2023 23:21
@methylDragon
Use "methods" instead of interface
de4c890 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 5132795 to de4c890 Compare April 5, 2023 20:40
wjwwood and others added 3 commits April 5, 2023 15:27
@wjwwood
fix comparison of wrong parameter to null
419a2f0 
Signed-off-by: William Woodall <william@osrfoundation.org>
@methylDragon
Add uchar header
2a62e8e 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Refactor to use ret types for description validity checks
84b5282 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from 1c7c9ad to 84b5282 Compare April 7, 2023 02:13
@methylDragon
Use create instead of init
8f55ada 
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
wjwwood requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the removal of the print functions and the refactoring of the create/init-allocator related refactoring (which we're going to do in a follow up pr if there's time, as it's nice-to-have only) this lgtm

will approve with print functions removed

@methylDragon
Remove print functions
d6a19a9 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon
Add identifier function
ecbb4bc 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon mentioned this pull request Apr 8, 2023
Merged
@methylDragon
Clean up style and README
e2d4f7a 
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the runtime_interface_reflection branch from ded432f to e2d4f7a Compare April 8, 2023 01:35
@wjwwood wjwwood merged commit de367f3 into rolling Apr 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the runtime_interface_reflection branch April 8, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjwwood wjwwood wjwwood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@methylDragon @wjwwood