Use init-on-first-use for global state#275
Merged
clalancette merged 2 commits intoros2:masterfrom Jan 7, 2021
Merged
Conversation
Otherwise global destructor ordering can result in the global state being destroyed before the last use. Not cleaning up does cause a small memory leak at shutdown, but it is limited to an empty map of domains and an empty unordered set of waitsets. Signed-off-by: Erik Boasson <eb@ilities.com>
clalancette
reviewed
Jan 6, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
The code looks OK to me. There's one style error inline I've pointed out.
I also think we should add a comment above the gcdds() function explaining why we are doing this and the tradeoff of never calling the destructor. That will help future readers understand.
Finally, a CI run with this in place, both with and without ros2/rmw#293, would be good to ensure that the problem there is solved.
Signed-off-by: Erik Boasson <eb@ilities.com>
clalancette
approved these changes
Jan 7, 2021
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
Looks good to me. I'm going to go ahead and run full CI on this both for the current state of the world, and in combination with ros2/rmw#293 to make sure things are happy.
Contributor
|
CI with just this PR in place:
|
Contributor
|
CI with this PR and ros2/rmw#293:
|
Contributor
|
All right, looking at the CI results with just this PR in place:
So as far as I can tell this PR is ready to go. I'm going to go ahead and merge, thanks @eboasson ! |
eboasson
added a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 17, 2021
* Use init-on-first-use for global state Otherwise global destructor ordering can result in the global state being destroyed before the last use. Not cleaning up does cause a small memory leak at shutdown, but it is limited to an empty map of domains and an empty unordered set of waitsets. Signed-off-by: Erik Boasson <eb@ilities.com>
clalancette
pushed a commit
to eboasson/rmw_cyclonedds
that referenced
this pull request
May 18, 2022
* Use init-on-first-use for global state Otherwise global destructor ordering can result in the global state being destroyed before the last use. Not cleaning up does cause a small memory leak at shutdown, but it is limited to an empty map of domains and an empty unordered set of waitsets. Signed-off-by: Erik Boasson <eb@ilities.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise global destructor ordering can result in the global state being
destroyed before the last use. Not cleaning up does cause a small memory leak
at shutdown, but it is limited to an empty map of domains and an empty
unordered set of waitsets.
Signed-off-by: Erik Boasson eb@ilities.com