Skip to content

Enable the property dds.ros.demangle_topic_and_type_names to announce the demangled topic name as a topic alias#221

Open
fgallegosalido wants to merge 1 commit intorollingfrom
feature/enable-topic-type-demangling
Open

Enable the property dds.ros.demangle_topic_and_type_names to announce the demangled topic name as a topic alias#221
fgallegosalido wants to merge 1 commit intorollingfrom
feature/enable-topic-type-demangling

Conversation

@fgallegosalido
Copy link
Collaborator

Description

Enable the property dds.ros.demangle_topic_and_type_names in the Connext RMW to announce the demangled topic name as a topic alias (documentation).

This property enables interoperability with Connext applications using the demangled topic name.

Is this user-facing behavior change?

Users using standalone Connext applications can interoperate with ROS 2 applications using the Connext RMW using the real topic names.

Did you use Generative AI?

No

Additional Information

This change was first introduced in Connext 7.5.0, and it's only enabled for that version onwards. When #218 is completed, we may need to add tests for this feature, but only on our RMW.

… the demangled topic name as a topic alias

Signed-off-by: Francisco Gallego Salido <fgallego@rti.com>
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is great improvement for interoperability!

@fujitatomoya
Copy link
Collaborator

Pulls: #221
Gist: https://gist.githubusercontent.com/fujitatomoya/66511ab61fae8dce7ca3e9cb58c8e0e8/raw/e554c30a0c47a7edf39b023677c655366396a041/ros2.repos
BUILD args: --packages-above-and-dependencies ‎rmw_connextdds_common
TEST args: --packages-above ‎rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18437

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants