Merged
Conversation
14 tasks
ihasdapie
force-pushed
the
service_introspection
branch
2 times, most recently
from
8bae776 to
6b27b3d
Compare
Member
Author
clalancette
force-pushed
the
service_introspection
branch
2 times, most recently
from
cba173e to
376ddca
Compare
clalancette
force-pushed
the
service_introspection
branch
5 times, most recently
from
67fdcaa to
869b7a5
Compare
clalancette
requested review from
adityapande-1995 and
sloretz
as code owners
clalancette
force-pushed
the
service_introspection
branch
from
869b7a5 to
11e4a74
Compare
Contributor
|
This has been substantially rewritten now, so I'm going to dismiss all of the review comments, and pull this out of draft. |
This make it more similar to the Service constructor. Also make both of them use const std::string & to avoid a copy. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Add in the parameters to control it, as well as the correct calls into the underlying rcl implementation. Also add in tests. Signed-off-by: Brian Chen <brian.chen@openrobotics.org> Signed-off-by: Chris Lalancette <clalancette@gmail.com>
To do this, we add a new method on the Client and Service classes that allows the user to change the introspection method at runtime. These end up calling into the rcl layer to do the actual configuration, at which point service introspection messages will be sent as configured. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
clalancette
force-pushed
the
service_introspection
branch
from
11e4a74 to
963b548
Compare
mjcarroll
approved these changes
Feb 27, 2023
Contributor
|
I should mention that CI for this is in ros2/ros2#1285 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a prototype implementation for ros-infrastructure/rep#360 ros2/ros2#1285.
Depends on: ros2/rcl#997