Skip to content

Make the test of graph users more robust. #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clalancette merged 1 commit into from
Jan 6, 2021
Merged

Make the test of graph users more robust. #1504

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions rclcpp/test/rclcpp/node_interfaces/test_node_graph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ class TestNodeGraph : public ::testing::Test
EXPECT_NO_THROW(node()->wait_for_graph_change(event, timeout));
}

// Run notify_graph_change() here to remove the graph_event users we created
// in the loop above.
node_graph_->notify_graph_change();

return num_things;
}

Expand Down Expand Up @@ -132,7 +128,7 @@ TEST_F(TestNodeGraph, construct_from_node)

// get_graph_event is non-const
EXPECT_NE(nullptr, node()->get_node_graph_interface()->get_graph_event());
EXPECT_EQ(1u, node_graph()->count_graph_users());
EXPECT_LE(1u, node_graph()->count_graph_users());
}

TEST_F(TestNodeGraph, get_topic_names_and_types)
Expand Down