Skip to content

Fix include order for cpplint #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobperron merged 1 commit into from
Jan 12, 2022
+31 −29
Merged

Fix include order for cpplint #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions rcl_logging_interface/test/test_get_logging_directory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,17 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <rcpputils/filesystem_helper.hpp>
#include <rcpputils/env.hpp>
#include <rcutils/allocator.h>
#include <rcutils/env.h>
#include <rcutils/error_handling.h>

#include <iostream>
#include <string>

#include "gtest/gtest.h"

#include "rcpputils/filesystem_helper.hpp"
#include "rcpputils/env.hpp"
#include "rcutils/allocator.h"
#include "rcutils/env.h"
#include "rcutils/error_handling.h"

#include "rcl_logging_interface/rcl_logging_interface.h"

// This is a helper class that resets an environment
Expand Down
14 changes: 7 additions & 7 deletions rcl_logging_spdlog/src/rcl_logging_spdlog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,20 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <rcpputils/filesystem_helper.hpp>
#include <rcutils/allocator.h>
#include <rcutils/logging.h>
#include <rcutils/process.h>
#include <rcutils/snprintf.h>
#include <rcutils/time.h>

#include <cerrno>
#include <cinttypes>
#include <memory>
#include <mutex>
#include <string>
#include <utility>

#include "rcpputils/filesystem_helper.hpp"
#include "rcutils/allocator.h"
#include "rcutils/logging.h"
#include "rcutils/process.h"
#include "rcutils/snprintf.h"
#include "rcutils/time.h"

#include "spdlog/spdlog.h"
#include "spdlog/sinks/basic_file_sink.h"

Expand Down
14 changes: 7 additions & 7 deletions rcl_logging_spdlog/test/fixtures.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
#ifndef FIXTURES_HPP_
#define FIXTURES_HPP_

#include <rcpputils/filesystem_helper.hpp>
#include <rcutils/allocator.h>
#include <rcutils/env.h>
#include <rcutils/error_handling.h>
#include <rcutils/process.h>
#include <rcutils/types/string_array.h>

#include <limits.h>
#ifdef _WIN32
# include <windows.h> // MAX_PATH
Expand All @@ -30,6 +23,13 @@

#include "gtest/gtest.h"

#include "rcpputils/filesystem_helper.hpp"
#include "rcutils/allocator.h"
#include "rcutils/env.h"
#include "rcutils/error_handling.h"
#include "rcutils/process.h"
#include "rcutils/types/string_array.h"

#ifdef _WIN32
#define popen _popen
#define pclose _pclose
Expand Down
19 changes: 10 additions & 9 deletions rcl_logging_spdlog/test/test_logging_interface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,21 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include <rcpputils/filesystem_helper.hpp>
#include <rcpputils/env.hpp>
#include <rcutils/allocator.h>
#include <rcutils/env.h>
#include <rcutils/error_handling.h>
#include <rcutils/logging.h>
#include <rcutils/testing/fault_injection.h>

#include <limits.h>
#include <fstream>
#include <string>

#include "fixtures.hpp"
#include "gtest/gtest.h"

#include "rcpputils/filesystem_helper.hpp"
#include "rcpputils/env.hpp"
#include "rcutils/allocator.h"
#include "rcutils/env.h"
#include "rcutils/error_handling.h"
#include "rcutils/logging.h"
#include "rcutils/testing/fault_injection.h"

#include "fixtures.hpp"
#include "rcl_logging_interface/rcl_logging_interface.h"

const int logger_levels[] =
Expand Down