Merged
Conversation
Relates to ament/ament_lint#324 Signed-off-by: Jacob Perron <jacob@openrobotics.org>
clalancette
reviewed
Jan 10, 2022
clalancette
reviewed
Jan 10, 2022
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
I'm OK with not changing the quotes.
However, I do think we are going to have to do something about the branches here. In particular it looks like the main branch is used for all of foxy, galactic, and rolling, and this PR should only apply to rolling. So I think we'll have to branch off.
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Member
Author
|
Looks like using double-quotes (1d0820f) satisfies both old and new versions of cpplint , so I don't think we need to branch. |
clalancette
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to ament/ament_lint#324