Skip to content

Conversation

@jeaninevbrr
Copy link

The default value as input enables choosing your own defaults for parameters in classes inheriting from filterBase.

For the discussion leading to this PR, see this PR on laser_filters.

@jonbinney
Copy link
Contributor

Thanks! This looks good - good you add default parameter to the documentation comment before each function?

@jonbinney
Copy link
Contributor

Oops typo mean to say "could you add default parameter to the documentation comment before each function?"

@jonbinney jonbinney self-assigned this Mar 25, 2025
@jonbinney
Copy link
Contributor

Hmmm... the tests didn't report results for some reason....

@jonbinney
Copy link
Contributor

@ros-pull-request-builder retest this please

@jonbinney
Copy link
Contributor

I'm going to close and reopen this to see if it triggers CI

@jonbinney jonbinney closed this Mar 26, 2025
@jonbinney jonbinney reopened this Mar 26, 2025
@jonbinney
Copy link
Contributor

I'm at a bit of a loss as to why the results of the checks aren't showing up for this PR. It looks like they are running (successfully, yay!) on the build farm, just not getting reported. The webhook seems setup properly for this repo, and it has test_pull_requests set to true in rosdistro: https://github.com/ros/rosdistro/blob/7ad64364be0088e1a0dd8a9020872fff6b8ae78d/humble/distribution.yaml#L2594

@tfoote @clalancette any ideas?

Copy link
Contributor

@jonbinney jonbinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I do want to get the CI sorted before merging though.

@jeaninevbrr
Copy link
Author

Sure! No worries, I am not on a tight schedule :)

@jonbinney jonbinney closed this Mar 31, 2025
@jonbinney jonbinney reopened this Mar 31, 2025
@jonbinney
Copy link
Contributor

I've switched over to github actions for running the tests, and they actually run now! Looks like uncrustify and cpplint are unhappy - looks like the line with the function signature is too long: https://github.com/ros/filters/actions/runs/14162352725/job/39669757509#step:6:445

@jeaninevbrr jeaninevbrr reopened this Mar 31, 2025
@jeaninevbrr
Copy link
Author

Fixed the linting tests. Not sure how I trigger test pipeline again

@jonbinney
Copy link
Contributor

Normally the actions trigger automatically when you push a commit, but for new committers github requires me to manually approve for security reasons. Tests pass! Thank you for this!

@jonbinney jonbinney merged commit 67b4ad6 into ros:ros2 Mar 31, 2025
4 checks passed
@jeaninevbrr jeaninevbrr mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants