Make git version detection more robust#101
Merged
leander-dsouza merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
This detection was previously updated to account for the 'windows' string appearing in the git version. It turns out that this practice isn't Windows-specific, and we should support non-digit version parts more generically. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
requested review from
claraberendsen and
leander-dsouza
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
==========================================
+ Coverage 26.96% 26.99% +0.03%
==========================================
Files 31 31
Lines 2240 2241 +1
Branches 393 393
==========================================
+ Hits 604 605 +1
Misses 1576 1576
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leander-dsouza
approved these changes
Feb 26, 2026
Member
leander-dsouza
left a comment
leander-dsouza
left a comment
There was a problem hiding this comment.
LGTM 🎉 , this makes it more resilient to git tags involving release candidates - 2.44.0.rc0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
This detection was previously updated to account for the 'windows' string appearing in the git version. It turns out that this practice isn't Windows-specific, and we should support non-digit version parts more generically.
Description of how this change was tested
pre-commit run --allpython3 -m pytest -s -v test