Set correct pull request message for --dry-run case#320
Merged
robwoolley merged 1 commit intoros-infrastructure:masterfrom Aug 1, 2025
Merged
Set correct pull request message for --dry-run case#320robwoolley merged 1 commit intoros-infrastructure:masterfrom
robwoolley merged 1 commit intoros-infrastructure:masterfrom
Conversation
When --only is used, if --dry-run is used it calls save_pr(), otherwise
file_pr() is called. This fix ensures that the same string value is
passed to the delta parameter of both functions.
The call to save_pr was incorrectly passing the list args.only instead
of the string delta which contains the contents of args.only
This caused a TypeError exception in get_pr_text when concatenating
the list to a string.
File ".../superflore/superflore/utils.py", line 59, in get_pr_text
msg += '\n' + delta + '\n'
~~~~~^~~~~~~
TypeError: can only concatenate str (not "list") to str
Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
nuclearsandwich
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When --only is used, if --dry-run is used it calls save_pr(), otherwise file_pr() is called. This fix ensures that the same string value is passed to the delta parameter of both functions.
The call to save_pr was incorrectly passing the list args.only instead of the string delta which contains the contents of args.only
This caused a TypeError exception in get_pr_text when concatenating the list to a string.
File ".../superflore/superflore/utils.py", line 59, in get_pr_text
msg += '\n' + delta + '\n'
~~~~~^~~~~~~
TypeError: can only concatenate str (not "list") to str