Resolve Flake8 conformance rules#316
Merged
robwoolley merged 2 commits intoros-infrastructure:masterfrom Jul 7, 2025
Merged
Conversation
When running the Flake8 tool it detects the global keyword being used unnecessarily: python -m flake8 superflore --import-order-style=google superflore/rosdep_support.py:48:5: F824 `global view_cache` is unused: name is never assigned in scope Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Contributor
Author
|
Hi @nuclearsandwich, I resolved the new flake8 conformance warnings. May I get your reviewer approval on my changes? |
nuclearsandwich
approved these changes
Jul 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the Flake8 tool it detects the global keyword being used unnecessarily:
python -m flake8 superflore --import-order-style=google
superflore/rosdep_support.py:48:5: F824
global view_cacheis unused:name is never assigned in scope