Update GitHub Actions workflow#301
Merged
robwoolley merged 8 commits intoros-infrastructure:masterfrom Nov 27, 2024
Merged
Conversation
robwoolley
force-pushed
the
master
branch
4 times, most recently
from
497425f to
128c32c
Compare
Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
This prevents trailing zeroes from being removed by making the values strings not numbers. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Use pynose for Python 3.11+ support Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Excluding tests for docker and for creating invalid directory paths. These tests do not seem relevant to testing superflore in a containerized CI/CD pipeline. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Update the checkout and setup-python actions to the latest versions. Remove Ubuntu 18.04 as a runner image as it has been deprecated by GitHub Actions and no longer has runners available. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
These steps follow the installation instructions from the Rolling Ridley documentation for setting up a new system. These changes are necessary to use the ros2 package repository for newer versions of Ubuntu. https://docs.ros.org/en/rolling/Installation/Ubuntu-Install-Debs.html Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Temporarily disable the ebuild unit tests. Support for Gentoo needs to be updated and the tests currently fail. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
Adding --verbose to python nose will print out the test cases names. This is useful for seeing what tests are being run when viewing the logs. Signed-off-by: Rob Woolley <rob.woolley@windriver.com>
nuclearsandwich
approved these changes
Nov 27, 2024
Contributor
nuclearsandwich
left a comment
nuclearsandwich
left a comment
There was a problem hiding this comment.
If it's possible to switch to pytest rather than keeping along with nose that's ideal, but if it's complicated and this works it can be punted on. It can also be done as a follow-up PR which is why I'm approving as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I saw that you asked for the CI workflow to be updated for #299
I did a quick run at making the necessary changes. The commits are clean however since I was working in the GHA workflow editor some commits failed and had to be corrected. (eg switching from nose to nose3 then to pynose) I am happy to rework the series if you feel it is necessary.
You may see the workflow test runs I did here: https://github.com/robwoolley/superflore/actions