Detect http test readiness with retry loop#200
Merged
Conversation
cottsay
force-pushed
the
cottsay/test-http-retry
branch
from
e3ab6e1 to
095af7b
Compare
cottsay
force-pushed
the
cottsay/test-http-retry
branch
from
095af7b to
6012bef
Compare
Member
Author
|
I don't really understand what's going on here, but some of the This retry loop should allow other platforms to continue running the tests quickly but will allow for the unpredictable performance we're seeing on macOS. |
Member
Author
|
We're seeing this in two recent PRs: |
tfoote
approved these changes
Oct 14, 2025
Member
tfoote
left a comment
tfoote
left a comment
There was a problem hiding this comment.
Thanks this is a better approach. Not sure what's going on with MacOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the existing static sleep.