Drop distutils as it is deprecated#194
Drop distutils as it is deprecated#194MatthijsBurgh wants to merge 7 commits intoros-infrastructure:masterfrom
Conversation
|
@tfoote @cottsay @mikepurvis please review this PR. |
tfoote
left a comment
There was a problem hiding this comment.
Sorry for the long delay reviewing. Thanks for contributing this. It's luckily a small tweak.
Can you rebase to a more recent commit to get the CI runs to trigger? Otherwise this looks great to add.
26f3055 to
3bfd0ad
Compare
|
@tfoote rebase done I need approval for a workflow run |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #194 +/- ##
=========================================
Coverage ? 39.85%
=========================================
Files ? 51
Lines ? 3264
Branches ? 661
=========================================
Hits ? 1301
Misses ? 1786
Partials ? 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The version of the git client on windows is |
|
@cottsay please respond to my previous comment |
|
I don't have any silver bullets here. We clearly need to get away from distutils, so I'd guess we'll have to do some intermediate processing, which is a bummer. I'm open to suggestions. |
e0c1535 to
92f0cda
Compare
|
I have no clue why the CI fails. As it runs on my account, https://github.com/MatthijsBurgh/rosdistro-1/actions/runs/21364087466 I had to restart it a few times. It looks more like a bug in GH actions than a failing pipeline. |
Agreed. Looks like they're finally acknowledging that there's an issue: https://www.githubstatus.com/incidents/90hj03y5tj3c |
|
This will need an update to |
@cottsay Done |
|
@cottsay please approve workflow run and review |
ca63251 to
5f63a4f
Compare
|
@cottsay done, please review |
No description provided.