Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
今週（2026-03-10）のパッチ反映として、アイテム/スキルのデータ（YAML）を更新するPRです。skill.yaml 側にも更新が入っているため、合わせてマージ対象になっています。
Changes:
skill.yaml：一部スキルの消費SP更新、NPC系スキル定義の追加item.yaml：新規アイテム/カード/装備の追加、既存アイテム説明文の文言更新
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| workspace/data/skill.yaml | SR_TIGERCANNONのSP更新、NPC系スキル定義を追加 |
| workspace/data/item.yaml | 新規アイテム/カード/装備を多数追加、説明文の文言を一部調整 |
Comment on lines
+5509
to
+5516
| - attack_range: '{}' | ||
| id: SR_TIGERCANNON | ||
| id_num: 2330 | ||
| max_lv: 10 | ||
| name: 號砲 | ||
| need_skill_list: '[{''skill_id'': ''SR_FALLENEMPIRE'', ''need_lv'': 3}]' | ||
| seperate_lv: true | ||
| sp_amount: '{0: 1, 1: 1, 2: 1, 3: 1, 4: 1, 5: 1, 6: 1, 7: 1, 8: 1, 9: 1}' | ||
| sp_amount: '{0: 30, 1: 35, 2: 40, 3: 45, 4: 50, 5: 55, 6: 60, 7: 65, 8: 70, 9: 75}' |
There was a problem hiding this comment.
[must] SR_TIGERCANNON の attack_range が従来のレベル別指定（全Lv=3）から '{}' に変更されています。utils/skillUtil.ts の変換ロジックでは空オブジェクトの場合、sp_amount 由来で「キーだけ作って値は null」の形式になり、射程情報が失われます（UI/計算で射程を参照する箇所がある場合に誤表示・不整合の原因になります）。射程が変更されていないのであれば、以前同様に全Lv分の値を明示して保持してください。
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
今週のパッチによるアイテム&スキル更新となります。
なお、いつからか skill.yaml にも更新有ったので合わせてマージお願いします。