Download ChEMBL schema files once per session#454
Merged
stitam merged 1 commit intoropensci:masterfrom Feb 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #449.
There was an inconsistency issue between webservice requests and offline queries: when a value was missing from the respective database, the webservice often returned
NULLbut the offline query returnedNAwith the appropriate class (e.g.NA_character_). In PR #450 I implemented a fix in which we download a schema file from the ChEMBL resource and use that to replaceNULLvalues with the appropriateNAvalues. However, downloading the schema with each query is inefficient.This PR implements session level caching. When we load the package we create a new environment
chembl_schema_cache. Whenever we need the schema file for a resource, we look for the schema in this environment. If we find it we use it, otherwise we download it and assign to the environment.PR task list:
devtools::document()