Feature bcpc extend features

[AlexisBrgn]

Pull Request

Brief description of the PR

Extended features from bcpc.R :

• Added locales to search from : Chinese, French, Russian
• Added identifier to search from : inchikey
• Refactored to easily add locales and identifier to search from.
• bcpc_query now returns locales

This PR is unsolicited but it was a shame the exposed functions didn't allow to search in other languages when the info was right there. I don't like refactoring other people's code but the existing codebase would've made extending features a bit messy.
Maybe this is the occasion to address #295? I'm not sure I understand it clearly tho.

PR task list:

• Update NEWS
• Add tests (if appropriate)
• Unit test extracted functions from the refactoring?
• Update documentation with devtools::document()
• Check package passed
• test-bcpc.R passed

[stitam]

Thanks @AlexisBrgn for opening this PR. Some of the webservices changed which broke a few tests we already had. I fixed these, can you please rebase on the current master? After rebase, please also rerun devtools::document(), this will remove man/webchem.Rd.

Is this PR still work in progress?

[AlexisBrgn]

Thanks for the heads up I'll dig into it as soon as I manage to free up some time to contribute.

Is this PR still work in progress?

Yes it is still very rough, the basic features work!

[Aariq]

#295 is basically saying we should return tibbles whenever possible rather than nested lists, if I remember correctly.

[Aariq]

I know this is still a WIP, but could you update the documentation to include info on the new from options when you get a chance? That would make it easier to give feedback on this PR.

[Aariq]

These URLs all appear to re-direct. E.g. http://www.bcpcpesticidecompendium.org/index-inchikey-frame.html, http://www.bcpcpesticidecompendium.org/index-zh-frame.html

[AlexisBrgn]

I admit I blindly pasted the format from the previous code.
These url actually redirect to http://www.bcpcpesticidecompendium.org.
For instance https://pesticidecompendium.bcpc.org/index_rn.html -[302]-> http://www.bcpcpesticidecompendium.org/index_rn.html
However the "redirection" to a *-frame.html is initiated by http://www.bcpcpesticidecompendium.org/index_{from}.html in javascript

if (top==self) self.location.href="index_rn_frame.html";

and should not happen when the code executes.
I will therefore replace all the URL to the format http://www.bcpcpesticidecompendium.org/index_{from}.html.

[stitam]

#295 is basically saying we should return tibbles whenever possible rather than nested lists, if I remember correctly.

Yes, I also think the issue was about returning tibbles. Mote than 4 years later I still think it's a good idea :) Without looking at the code in the PR I would think tibbles may be out of scope for this PR but if it's already done, great :)

[AlexisBrgn]

#295 is basically saying we should return tibbles whenever possible rather than nested lists, if I remember correctly.

Yes, I also think the issue was about returning tibbles. Mote than 4 years later I still think it's a good idea :) Without looking at the code in the PR I would think tibbles may be out of scope for this PR but if it's already done, great :)

Looking at the code I think it is out of scope too, but I'm willing to tackle the issue in another PR.